ui: Remove some javascript files we no longer use #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
feature/ui-js-cleanup
branch
from
efd8e23 to
49f8e07
Compare
meirish
approved these changes
Dec 9, 2019
|
Yeah, and from the initial build were we had browser |
johncowen
force-pushed
the
ui-staging
branch
from
6830f7c to
3e381a7
Compare
added 2 commits
December 11, 2019 10:17
We also referred to confirm/error in the confirmation dialog, but they were never used (ever since we moved from native dialogs to HTML ones). We lef tthe ability to use native dialogs, but we are never going to go back there so we may as well remove them now.
johncowen
force-pushed
the
feature/ui-js-cleanup
branch
from
49f8e07 to
454d781
Compare
johncowen
added a commit
that referenced
this pull request
Dec 17, 2019
johncowen
added a commit
that referenced
this pull request
Dec 18, 2019
|
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..we almost removed
writablealso but would rather do that as a different PR as it isn't purely removing things, we'd have to change the things that use it to do something like mention in the PR description of #6285. Instead of doing it here, we left a couple of todos for the future.